Open
Conversation
Includes phone dialer menu from feature/phone branch - but does not include directory menus. Phone book can be tested using CLI only ... "BT PB" (phone book), "BT CH" (call history) and "BT FAV" (favorites)
Includes phone dialer menu from feature/phone branch - but does not include directory menus. Phone book can be tested using CLI only ... "BT PB" (phone book), "BT CH" (call history) and "BT FAV" (favorites)
…BlueBus into feature/phonebook # Conflicts: # firmware/application/lib/bt/bt_bm83_pbap.c
…BlueBus into feature/phonebook # Conflicts: # firmware/application/lib/bt/bt_bm83_pbap.c
…BlueBus into feature/phonebook
Owner
|
Thank you for your work here! There are some other features that need to be merged in before this, so I will get to this ASAP. I may also change some of the code, etc once merged, but at a high level it seems to align well with the rest of the codebase. I think this is what you're looking for: https://github.com/piersholt/wilhelm-docs/blob/master/telephone/directory.md Thanks! |
Author
|
Hope it's helpful.Thank you for a great open-source product, Ted.
I have read that site, and the feature/phone branch, but I still couldn't work out how to get the directory screen to show :-(I'll keep trying...
On Sunday, 25 February 2024 at 09:50:17 pm AWST, Ted Salmon ***@***.***> wrote:
@ticklemonster
Thank you for your work here! There are some other features that need to be merged in before this, so I will get to this ASAP. I may also change some of the code, etc once merged, but at a high level it seems to align well with the rest of the codebase.
I think this is what you're looking for: https://github.com/piersholt/wilhelm-docs/blob/master/telephone/directory.md
Thanks!
-Ted
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Collaborator
|
Hi @ticklemonster ! Nice to meet you an see you already contributing! I have quite a few lines of code in my uncommited changes, dealing with storing and updating phonebook in BlueBus for caller id, and for directory management, that I just did not manage to find mental power to complete. If you would like to have a look at them, and join the effort, I would love to work with you. Maybe join the BB slack to discuss? |
Author
|
Happy to try and help. I did try to take on some of the code from feature/phone. I roughly understood how the dial screen worked, can see the button messages, but couldn’t work it how to get the directory screen up with my content. 😔
I’m in Western Australia, so time zones can be tricky. Happy to get involved on slack Where’s the slack channel?
On Tuesday, February 27, 2024, 12:59 am, Ivan Debnar ***@***.***> wrote:
Hi @ticklemonster ! Nice to meet you an see you already contributing!
I have quite a few lines of code in my uncommited changes, dealing with storing and updating phonebook in BlueBus for caller id, and for directory management, that I just did not manage to find mental power to complete. If you would like to have a look at them, and join the effort, I would love to work with you. Maybe join the BB slack to discuss?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Owner
|
What’s your email? I’ll add you. -Ted |
Author
|
Try ***@***.***
On Tuesday, February 27, 2024, 4:11 pm, Ted Salmon ***@***.***> wrote:
@ticklemonster
What’s your email? I’ll add you.
…-Ted
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
tedsalmon
force-pushed
the
master
branch
2 times, most recently
from
316264a to
c9513df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some features to read the phone book from a BM83 (bluebus v2).
You can test it from the CLI, but they are not added to any UI.
I've merged in some of the phone UI from feature/phone, but I don't know how to get the directory menu to show up.
Any advice on getting the directory screen to work?